uwarp-space 2026-02-28
Gold ship instances wired, 25+ code review rounds resolved, and import boundary checker extended
218 files · 11,787+ · 1,107-

Gold ship instances fully wired

instantiate behavioral
4 files changed
  • _gold_ship_sync.py Gold ship state sync through player loads and saves
  • game_loader.py Gold ship instances restored from sqlite
  • game_saver.py Gold ship instances persisted to storage
  • game_state.py Gold ship state hydration and capacity alignment
  • Restored gold ship instances from sqlite on game load instantiate behavioral
    2 files
    • game_loader.py
    • _store_loaders.py
  • Persisted gold death count in header records instantiate internal
    1 file
    • game_saver.py
  • Hydrated gold ship names into players and aligned displays with instance holds instantiate behavioral
    2 files
    • game_state.py
    • _gold_ship_sync.py
  • Applied gold bonus holds to capacity and honored gold ship hold capacity instantiate behavioral
    1 file
    • _purchases_shipyard.py
  • Showed gold ship state in shipyard display instantiate internal
    1 file
    • _purchases_hardware.py
  • Synced gold ship state through player loads and saves remediate internal
    1 file
    • _gold_ship_sync.py
  • Persisted dirty players back to dat files remediate internal
    1 file
    • _game_state_persistence.py
  • Kept gold ship instances in sqlite game loads; deduped ship instances during export remediate internal
    2 files
    • _store_loaders.py
    • _store_schema.py
  • Preserved unknown ferrengi AI states during storage harden internal
    1 file
    • alien.py

Game rules fixes across 25+ code review rounds

remediate behavioral
5 files changed
  • combat.py PvP cloaking, photon disables, and combat mode fixes
  • encounter.py Alien encounter dirty state and mine ownership fixes
  • robbery.py Robbery port stock fixes
  • banking.py Bank cap fixes
  • deploy.py Deploy and mine ownership fixes
  • Code review #25: photon disables, mine ownership, bank cap, alien encounter dirty, ISS dirty remediate internal
    4 files
    • combat.py
    • deploy.py
    • banking.py
    • test_code_review_25.py
  • Code review #27: cloak sale regression, PvP cloaking, cargo colonists, sysop delete, ISS cloak guard remediate internal
    3 files
    • combat.py
    • equipment.py
    • test_code_review_27.py
  • Code review #28: robbery port stock, alien combat dirty, fed police colonists, mine owner remediate internal
    3 files
    • robbery.py
    • encounter.py
    • test_code_review_28.py
  • Code reviews #7-#9: 28 issues covering mark_dirty gaps, corp password hashing, login loop fix, and attribute errors remediate internal
    2 files
    • management.py
    • login.py
  • Code review #20: ownership checks, transport scoping, mutual combat death, price signal remediate internal
    2 files
    • planet.py
    • test_code_review_20.py
  • Code review #21: game rules accuracy corrections remediate internal
    2 files
    • movement.py
    • test_code_review_21.py
  • Code reviews #22-#24: rank, deploy, corp, alien death, combat mode fixes remediate internal
    4 files
    • corporation.py
    • test_code_review_22.py
    • test_code_review_23.py
    • test_code_review_24.py
  • Fourth and fifth code review passes: mark_dirty, post_hop_fn, crash fixes, auth, sync_player_sector remediate internal
    2 files
    • movement.py
    • engine.py
  • Code review #17-#18: unwired constants, dead logic, display gaps, photon rule, disruptor partial clear, merc hire, comms cap remediate internal
    2 files
    • constants.py
    • comms.py
  • Added mark_dirty regression tests for all mutating commands qualify internal
    1 file
    • test_commands_mark_dirty.py

SysOp API extended with new endpoints

instantiate behavioral
1 file changed
  • config.py Sector wipe, corp membership, force tick, and ship assign endpoints
  • Added sector wipe, corp membership, force tick, and ship assign endpoints to sysop API instantiate behavioral
    1 file
    • config.py
  • Wired serve command to CLI; added sysop API integration tests instantiate internal
    2 files
    • __init__.py
    • test_worker_sysop.py

Storage persistence and parser improvements

instantiate internal
2 files changed
  • _config_fields_data.py Config field data parser improvements
  • _game_state_persistence.py Game state persistence improvements
  • Persisted citadel transporter in sqlite exports and planet records instantiate internal
    2 files
    • _store_schema.py
    • _game_state_persistence.py
  • Verified citadel transporter command integration qualify internal
    2 files
    • test_citadel_transporter.py
    • test_transport_persistence.py
  • Wired 8 unwired game mechanics from code reviews instantiate internal
    2 files
    • hardware.py
    • shipyard.py
  • Wired atmosphere/shields purchase, fixed retreat costs, loan interest, and bounty validation instantiate internal
    2 files
    • _management_atmosphere.py
    • banking.py
  • Wired LOAN_DANGER_MULTIPLIER, surrender combat resolution, deduplicated VALID_COMMODITIES remediate internal
    2 files
    • economy.py
    • _combat_apply.py
  • Improved gold dat parsing and runtime config coverage instantiate internal
    1 file
    • _config_fields_data.py
  • Fixed move get_planet out of init, fixed sentinel guard, and 8 engine bugs remediate internal
    2 files
    • __init__.py
    • management.py
  • Corrected off-by-one planet indexing, restored fighter retrieval, fixed combat/planet bugs remediate internal
    2 files
    • planet.py
    • _combat_models.py
  • Fixed 9 planet/combat/tick correctness bugs remediate internal
    2 files
    • combat.py
    • planet.py

Worker unit test coverage expanded

qualify internal
3 files changed
  • test_adapter.py Worker adapter unit tests
  • test_sysop_helpers.py Worker sysop helpers unit tests
  • test_fetch_router.py Worker fetch router unit tests
  • Expanded worker unit test coverage for adapter, sysop_helpers, and fetch_router qualify internal
    3 files
    • test_adapter.py
    • test_sysop_helpers.py
    • test_fetch_router.py

Import boundary checker extended

qualify internal
1 file changed
  • check_import_boundaries.py Import boundary checker extended to full AGENTS.md ownership matrix
  • Extended import boundary checker to full AGENTS.md ownership matrix qualify internal
    2 files
    • check_import_boundaries.py
    • AGENTS.md
  • Added skipif guard for test_game_api_models; fixed maintenance prefix in boundary checker remediate internal
    1 file
    • check_import_boundaries.py
  • Resolved all pre-existing ruff and mypy gate failures baseline errata
    2 files
    • trading.py
    • transwarp.py
  • Fixed import sort in test_player_api_exports baseline errata
    1 file
    • test_player_api_exports.py

Session safety guard

harden internal
1 file changed
  • session.py Guarded confirm() against UnboundLocalError when session is inactive
  • Guarded confirm() against UnboundLocalError when session is inactive harden internal
    1 file
    • session.py
  • Added confirm() regression test and fixed _maintenance prefix gap in boundary checker qualify internal
    2 files
    • test_code_review_26.py
    • check_import_boundaries.py
  • Added tunable and menu inventory reference documentation specify internal
    3 files
    • config-tunable-matrix.md
    • menu-screen-inventory.md
    • config-runtime-coverage.md
  • Wired announcement fee and finalized config stubs; wired undef-terminal into workspace instantiate internal
    2 files
    • social.py
    • pyproject.toml
  • Excluded undef-terminal from import boundary checks baseline internal
    1 file
    • check_import_boundaries.py
← 2026-02-27 uwarp-space changelog → 2026-03-01 uwarp-space →