bbsbot 2026-02-26
Code review fixes: logging style, task safety, MCP registry extraction, and mypy narrowing cleanup
343 files · 4,704+ · 3,279-

Code review fixes

interface behavioral
23 files changed
  • registry.py MCP tool registry extracted into dedicated module (10 lines added)
  • sequence.py Login flow logging style and safety improvements (39 lines)
  • phases.py Login phase logging and safety improvements (32 lines)
  • loop_guards.py Game action logging and task safety (22 lines)
  • executor_trade.py Trade executor logging and task safety (22 lines)
  • loop_handlers.py Loop handlers logging and task safety (20 lines)
  • executor_warp.py Warp executor logging and task safety (16 lines)
  • guard_decision.py Guard decision logging and task safety (12 lines)
  • __init__.py MCP tools wiring updated (10 lines)
  • control_basic.py MCP tools wiring updated (20 lines)
  • tools_core.py MCP tools wiring updated (6 lines)
  • upgrades.py Type narrowing cleanup (12 lines)
  • combat.py Type narrowing cleanup (10 lines)
  • character.py Type narrowing cleanup (10 lines)
  • bot_navigation.py Type narrowing cleanup (10 lines)
  • banking.py Type narrowing cleanup (6 lines)
  • goals.py Strategy goal cleanup (10 lines)
  • io.py IO cleanup (8 lines)
  • connection.py Connection cleanup (7 lines)
  • character_creation.py Character creation cleanup (8 lines)
  • loop_state.py Loop state cleanup (6 lines)
  • monitor.py TUI monitor cleanup (5 lines)
  • session.py Session cleanup (2 lines)
  • src/bbsbot/games/tw2002/mcp_tools/registry.py (10 lines added) — MCP tool registry extracted into dedicated module decouple internal
    1 file
    • registry.py
  • src/bbsbot/games/tw2002/login/sequence.py (39 lines), login/phases.py (32 lines) — login flow logging style and safety improvements decouple errata
    2 files
    • sequence.py
    • phases.py
  • src/bbsbot/games/tw2002/game_actions/loop_guards.py (22 lines), executor_trade.py (22 lines), loop_handlers.py (20 lines), executor_warp.py (16 lines), guard_decision.py (12 lines) — game action logging and task safety decouple behavioral
    5 files
    • loop_guards.py
    • executor_trade.py
    • loop_handlers.py
    • executor_warp.py
    • guard_decision.py
  • src/bbsbot/games/tw2002/mcp_tools/__init__.py (10 lines), control_basic.py (20 lines), tools_core.py (6 lines) — MCP tools wiring updated interface internal
    3 files
    • __init__.py
    • control_basic.py
    • tools_core.py
  • src/bbsbot/games/tw2002/upgrades.py (12 lines), combat.py (10 lines), character.py (10 lines), bot_navigation.py (10 lines), banking.py (6 lines) decouple internal
    5 files
    • upgrades.py
    • combat.py
    • character.py
    • bot_navigation.py
    • banking.py
  • src/bbsbot/games/tw2002/strategies/ai/goals.py (10 lines), profitable_pairs/action_helpers.py (6 lines) decouple internal
    1 file
    • goals.py
  • src/bbsbot/games/tw2002/io.py (8 lines), connection.py (7 lines), login/character_creation.py (8 lines), loop_state.py (6 lines) decouple internal
    4 files
    • io.py
    • connection.py
    • character_creation.py
    • loop_state.py
  • src/bbsbot/tui/swarm_monitor/monitor.py (5 lines), swarm/__init__.py (2 lines), web/__init__.py (2 lines) decouple internal
    1 file
    • monitor.py
  • src/bbsbot/core/session.py (2 lines), worker/diagnostics.py (4 lines) decouple internal
    1 file
    • session.py
← 2026-02-25 bbsbot changelog → 2026-02-27 bbsbot →